grafana / grafana/pyroscope

Python labels don't appear to follow threads

Open
#1,077 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11.7k
Forks
802
Avg merge
1d 19h
Merged PRs (30d)
80

Description

I'm working on tracking down a redis usage issue in a multi-threaded application so I wrapped several calls to redis_client.get with various labels in python 3.7, but it's not correctly filtering my stack traces. For instance this block
```
with pyroscope.tag_wrapper({ "redis": "my_listener.one_loop" }):
self.overall_status = self.redis_client.get(RedisKeys.overall_status_key)
```
should only return a trace for calls to redis/client.py, but it seems to just grab the entire applications stack trace during that time across all open threads
![image](https://user-images.githubusercontent.com/65615298/166329884-fb434854-4112-4bca-8f10-b564a0bae088.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.