grafana / grafana/pyroscope-java

Sub-optimal memory leak capabilities with Pyroscope Java agent

Open
#94 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
126
Forks
48
Avg merge
4d 14h
Merged PRs (30d)
5

Description

Hi,

I’m trying to use Grafana Pyroscope to find a simulated memory leak in a small example program. I have two methods called leak() and noLeak() where the leak() method saves data to a Set every time it is called and noLeak() only allocates some memory that will be garbage collected. When I use Async Profiler (2.9) locally with the –live option I see that the leak() method is “leaking” memory. When I try to use the Pyroscope agent instead (io.pyroscope:agent:0.11.3) I don’t see it nearly as clearly.
![async-large](https://user-images.githubusercontent.com/6833253/236852717-2681d10f-1a10-4e5f-9dfd-9394246e33fe.png)
![pyroscope-large](https://user-images.githubusercontent.com/6833253/236852739-ad910dbe-4ffe-42ed-90b9-a5a81edc3274.png)
![pyro-zoom](https://user-images.githubusercontent.com/6833253/236852904-e3ffc9a0-e9d8-47d6-a4aa-0cfb69561124.png)
![async-zoom](https://user-images.githubusercontent.com/6833253/236852919-bd578678-7b7e-4a6b-b047-21ecfe7b9994.png)

I used the following configuration when setting up the Pyroscope Java agent:

```
Config config = new Config.Builder()
.setApplicationName("leaktest-1")
.setFormat(Format.JFR)
.setServerAddress("http://localhost:4040/")
.setUploadInterval(Duration.ofSeconds(10))
.setProfilingEvent(EventType.ALLOC)
.setAllocLive(true)
.build();
```

When I run the async profiler, locally, for 60s or more then I can easily see the memory leak. When I run the async profiler for 10s or less than I observe the same behavior as I see with Pyroscope.
![async-10](https://user-images.githubusercontent.com/6833253/236853040-3ba087b1-75b4-40a4-8b75-b35ab8b997d9.png)

I also tried to change the upload interval of the Pyroscope Java agent to 60s, but I am still not able to see the memory leak in a good way.

Slack thread: https://grafana.slack.com/archives/C049PLMV8TB/p1683294542388929

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.