grafana / grafana/pyroscope-java

Add hot config reload

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
126
Forks
48
Avg merge
4d 14h
Merged PRs (30d)
5

Description

Add configurable hot config file reload mechanism to support kube ConfigMap pyroscope.properties updates that dont trigger restart.

Linux inotify (upon which the jvm watch service virtualizes) has pitfalls, like inability to track NAS which are provided in modern clouds (like Amazon EFS NAS). I guess other OSs have push pitfalls, too. Also, some OSs dont support push, so the jvm polls internally. Thus, I would suggest pull model with 15m or so default interval configurable via --config-check-interval and a /reload real time endpoint.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.