grafana / grafana/pyroscope-dotnet

log ingest error message body

Open
#69 0 comments 4 reactions 1 assignee Claimed by @korniltsev View on GitHub
Dominant language
C++
Stars
38
Forks
13
Avg merge
20h 15m
Merged PRs (30d)
10

Description

Error messages like these are not very useful for troubleshooting especially if you do not own the pyroscope server.
```
[2024-08-12 23:36:40.305 | info | PId: 1 | TId: 16] PyroscopePprofSink 400
[2024-08-12 23:36:40.305 | info | PId: 1 | TId: 16] PyroscopePprofSink 422
```

The http response body should contain a useful error, like `name: invalid tag key: service.namespace: character is not allowed: '.'` or `pushing IngestInput-pprof failed invalid_argument: profile with labels '{__delta__=\"false\", __name__=\"wall\", deployment_environment=\"dev\", pyroscope_spy=\"dotnetspy\", service_name=\"webmvc\", service_name=\"webmvc\", service_namespace=\"eshop\"}' has duplicate label name`. Which we should include in the info log message to aid troubleshooting

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.