grafana / grafana/jsonnet-libs

Consider removing the default `super.withImagePullPolicy('IfNotPresent')` for containers

Open
#752 1 comment 0 reactions 0 assignees View on GitHub
stale
Dominant language
Jsonnet
Stars
732
Forks
188
Avg merge
3d 1h
Merged PRs (30d)
5

Description

Since [k8s now sets the imagePullPolicy automatically upon creation](https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting), setting it to `IfNotPresent` for the container to be valid is not required anymore.
https://github.com/grafana/jsonnet-libs/blob/98c3060877aa178f6bdfc6ac618fbe0043fc3de7/ksonnet-util/grafana.libsonnet#L19

Overriding things like this can be cumbersome with jsonnet so it would be nice to not be forcing this on all containers created using the library. Either removing this default entirely or just making the default pull policy value configurable "globally" would be greatly appreciated.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.