grafana / grafana/flux-commit-tracker

Fix inaccurate measurements after tracker restarts

Open
#496 0 comments 0 reactions 1 assignee Claimed by @dblinkhorn View on GitHub
Dominant language
Go
Stars
5
Forks
1
Avg merge
5d 7h
Merged PRs (30d)
22

Description

On startup `flux-commit-tracker` can measure an already-applied revision using its latest reconciliation timestamp instead of its original apply time. This causes a commit that got applied in a typical, expected amount of time to be reported again with a highly inflated cycle time due to it using the current, rather than original, apply time of that OCI revision. This distorts the accuracy of the metrics and can even trigger false-alarm alerts. Also, retries etc can end up reading a newer revision or timestamp than the update that originally queued the measurement.

To address these issues we should:

- Skip measurements for existing revisions discovered at process startup
- Preserve the revision and original apply timestamp throughout processing and retries

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.