Improve test coverage for implicit includes for Assemble and WindowsResourceCompile
- Dominant language
- No language data
- Stars
- 94
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
The `Assemble` and `WindowsResourceCompile` do not extend from `AbstractNativeCompileTask` and are configured by `WindowsResourcesCompileTaskConfig` and `AssembleTaskConfig` instead of `CompileTaskConfig`.
This caused a [regression](https://github.com/gradle/gradle/issues/3662) in 4.4 RC4, since we did not add the Visual Studio SDK system includes for those tasks. We fixed this regression for 4.4 RC5, but the tests still need some love.
Moreover, on `master` we already [improved system header tracking](https://github.com/gradle/gradle-native/issues/281), so we would need to make that handling work with the changes on `release`.
Contributor guide
Research direction
Compare the release and master handling for implicit includes, starting with AssembleTaskConfig and WindowsResourcesCompileTaskConfig and the related test coverage. Read the regression in issue 3662 and the system header tracking changes in issue 281. Done means tests cover implicit includes for both Assemble and WindowsResourceCompile without regressing the release behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100