grab / grab/grazel

BUILD.bazel not generated.

Open
#47 1 comment 0 reactions 1 assignee View on GitHub

@arunkumar9t2 is already working on this.

Since Dec 6, 2022.

Dominant language
Kotlin
Stars
299
Forks
25
PR merge metrics
No merged PRs in 30d

Description

Problem 1.
Not sure why this is happening but it seems like some of my modules getting the Deleted test/test_fixtures_ui/BUILD.bazel and I don;t see the migrated BUILD.bazel file

> Task :test:test_fixtures_ui:generateBazelScripts
Deleted test/test_fixtures_ui/BUILD.bazel

> Task :test:test_fixtures:generateBazelScripts
Generated test/test_fixtures/BUILD.bazel

my config

grazel {
    android {
        features {
            dataBinding = true
        }
        variantFilter {
            this.setIgnore(name != "release" && name != "prodEnv")
        }
        ndkApiLevel = 28
    }

    rules {
        bazelCommon {
            gitRepository {
                commit = "646475fa68b984f476871f0e8073234e8cae559c" // Commit hash
                remote = "https://github.com/grab/grab-bazel-common.git"
            }
        }
        test {
            enableTestMigration = true
            detectSourceSets = true
        }
        dependencies {
            overrideArtifactVersions.add("androidx.navigation:navigation-runtime:2.3.2")
        }
        mavenInstall {
            httpArchiveRepository {
                sha256 = "b17d7388feb9bfa7f2fa09031b32707df529f26c91ab9e5d909eb1676badd9a6"
                stripPrefix = "rules_jvm_external-4.5"
                url = "https://github.com/bazelbuild/rules_jvm_external/archive/4.5.zip"
            }
            artifactPinning {
                enabled.set(false)
            }
            versionConflictPolicy = "pinned"
        }
    }

Problem 2.

When I enable artifactPinning I get dependency conflict ->

Error in fail: Error while fetching artifact with coursier: Resolution error: Conflicting dependencies:
androidx.navigation:navigation-runtime:2.3.2 or [2.3.0] or [2.4.0] wanted by

  androidx.hilt:hilt-navigation:1.0.0 wants 2.3.2
  └─ androidx.hilt:hilt-navigation-compose:1.0.0

  androidx.navigation:navigation-fragment:2.3.0 wants [2.3.0]
  └─ com.datadoghq:dd-sdk-android:1.15.0

  androidx.navigation:navigation-runtime-ktx:2.4.0 wants [2.4.0]
  ├─ androidx.navigation:navigation-compose:2.4.0 wants androidx.navigation:navigation-runtime-ktx:[2.4.0]
  │  └─ androidx.hilt:hilt-navigation-compose:1.0.0
  └─ com.datadoghq:dd-sdk-android:1.15.0 wants androidx.navigation:navigation-runtime-ktx:2.3.0

but adding overrideArtifactVersions.add("androidx.navigation:navigation-runtime:2.3.2") doesn't work at all.

and I do get the same

> Task :test:test_fixtures_ui:generateBazelScripts
Deleted test/test_fixtures_ui/BUILD.bazel

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.