graasp / graasp/graasp-apps-query-client
Should we use function in this factory ?
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
I am not sure, but maybe you do not need the function, as you are likely to always return the same value. The others are function so their return value is given when they are called and not the value that they have when the factory is created.
_Originally posted by @spaenleh in https://github.com/graasp/graasp-apps-query-client/pull/69#discussion_r1083723194_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the factory discussed in pull request #69 and compare it with the other factories mentioned in the discussion. Determine whether its value should be fixed at factory creation or returned through a function, then verify that the resulting behavior matches the existing factory convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100