graasp / graasp/graasp-apps-query-client
Move type and protocol definitions to SDK
Open
chore
refactor :wrench:
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
> I guess it's copy-pasted from query-client. Should we put that in sdk? Or in graasp-websockets?
_Originally posted by @pyphilia in https://github.com/graasp/graasp-apps-query-client/pull/142#discussion_r1284515695_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading the discussion from graasp-apps-query-client pull request #142 and locating the copied type and protocol definitions in the query-client code. Compare whether the SDK or graasp-websockets is the appropriate home; done means the ownership decision is implemented and references are updated consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100