graasp / graasp/graasp-api

Save member's lang in a separated column

Open
#1,392 0 comments 0 reactions 1 assignee Claimed by @Defferrard View on GitHub
feature
Dominant language
TypeScript
Stars
7
Forks
5
PR merge metrics
No merged PRs in 30d

Description

The idea would be to ease the front end where `currentMember.lang` would be easily feasible.

Currently: `currentMember.type === Individual && currentMember.extra.lang`
There are two problems: lang is saved in extra, which only exists in Members. We have to check the type to know if we can access extra.

------

To go further: we want to remove the `extra` column. It currently contains:
```
type MemberExtra = {
hasAvatar?: boolean;
lang?: string;
emailFreq?: `${EmailFrequency}` | EmailFrequency;
hasCompletedTour?: boolean;
};
```
We can remove hasCompletedTour.
If we make a packed member with the avatar, we would not need `hasAvatar`. Or we keep it to prevent call during the pack logic.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.