graasp / graasp/graasp-api

Refactor ValidatePermission

Open
#1,161 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Currently, the permission validation has too many issues.

1. It sends too much SQL queries
2. Pseudonymized accounts should not have an ItemMembership
3. We cannot customise permission for a user. by exemple: sometimes we want writters to be able to delete sometimes we don't want to

A suggestion would be to have :

1. A TypeORM view (It allows only READ request on the database) which contains
- AccountId
- ItemId
- Permission
For each account and item
**It would solve** the amount of SQL Queries, the current complexity of the validation process, the multiple way we have to validate permissions

2. Check permission on prehandler
But sometimes we want to retrieve the permission of an item to the frontend
It would solve the current complexity

3. Having custom roles
**It would solve** the permission customisation issue

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.