graasp / graasp/client

Deprecations are not visible in clients

Open
#886 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
TypeScript
Stars
0
Forks
4
PR merge metrics
No merged PRs in 30d

Description

## Issue

When marking a hook as deprecated in query-client it does not show in the client code.
This is due to two things:
- we do not keep the comments
- we spread the return from the hooks, so we loose the deprecation

## Solution
If we can remove the need for the `configureHooks` this issue can be resolved.
For this we need to remove the need for the `API_HOST` env variable.
This can be done by calling the api on the same host, by removing the crossOrigin issue.
If we remove the crossOrigin calls we can also remove the usage of the `withCredentials` that is added in the `configureAxios` function.

In summary if we move to a single origin architecture with the api running on the `/api` subpath and apps running on their own paths (`/builder` etc).

To solve the issue of the local development we could use [the proxy feature from the vite development server](https://vitejs.dev/config/server-options#server-proxy) which would allow to have requests to `/api` go to `http://localhost:3000` instead of `http://localhost:3111/api` (for builder for example).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.