mx doesn't support `http_proxy`s requiring authorization (aka following the format `http://user:password@host:port`)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 205
- Forks
- 129
- PR merge metrics
- No merged PRs in 30d
Description
mx appears to only support unauthorized http_proxys following the format http://host:port while it should also support http://user:password@host:port and set http.proxyUser and http.proxyPassword accordingly.
The code at fault is:
https://github.com/graalvm/mx/blob/29c0debab406352df3af246be2f8973be5db69ae/mx.py#L12966-L12981
and
https://github.com/graalvm/mx/blob/29c0debab406352df3af246be2f8973be5db69ae/mx.py#L13007-L13012
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the proxy handling in mx.py at lines 12966-12981 and 13007-13012. Trace how an http://host:port proxy is parsed, then verify that an http://user:password@host:port proxy sets http.proxyUser and http.proxyPassword; the work is done when authorized proxies are supported without breaking unauthorized ones.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100