gr2m / gr2m/octokit-plugin-create-pull-request

Binary files fail on forked repositories

Open
#81 5 comments 0 reactions 0 assignees View on GitHub
released
Dominant language
TypeScript
Stars
116
Forks
31
PR merge metrics
No merged PRs in 30d

Description

When trying to create a commit with a binary file (e.g. image), this request fails with a 404 on a forked scenario (user does not have rights to push to repo).

https://github.com/gr2m/octokit-plugin-create-pull-request/blob/682ea7b47c16ce2b13bc07b09d201ea30381770b/src/value-to-tree-object.ts#L30

Is it the case that it should be `owner: fork` instead of `owner` ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.