gr2m / gr2m/node-http-recorder

Event not emitted with all errors

Open
#35 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
6
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Certain http errors are not causing the "record" event to be emitted, making my http recorder logic not run. For example, if I call a url that doesn't exist (and I would imagine timeouts). I would like to be able to record events like this for testing purposes

I believe this is because you are hooking into the node "response" event, which is probably not fired for errors in which there is no response, like timeouts. What do you think?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.