goxr3plus / goxr3plus/java-stream-player

setEqualizer doesn't work?

Open
#58 2 comments 0 reactions 1 assignee Claimed by @HelgeStenstrom View on GitHub
bug
Dominant language
Java
Stars
158
Forks
36
PR merge metrics
No merged PRs in 30d

Description

https://github.com/goxr3plus/java-stream-player/blob/6a00a79f32bf324f7d6232182d93745da64bee0b/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L1250-L1257

I can't see that this method has any side effect, desired or not. It copies an array passed to it, into a local variable, and when the method goes out of scope, the copy is lost.

What is the intention with the method? If it never has worked as intended, maybe it should be removed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.