goxr3plus / goxr3plus/java-stream-player

Unused code

Open
#2 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
158
Forks
36
PR merge metrics
No merged PRs in 30d

Description

I am currently trying to re-implement a player based on Javax.soundand thus trying to understand the implementation here,
In the course of that process, I stumbled upon a piece of code that seems like it isn't used:

In the method `createLine()` The Assignment In StreamPlayer.java Line 481 makes the two assignments to sourceDataLine in L474 and L478 superfluos.

https://github.com/goxr3plus/java-stream-player/blob/2f7d16dcf689a5335e91fe91bd6bfbdfe173cd6e/src/main/java/goxr3plus/javastreamplayer/stream/StreamPlayer.java#L472-L481

If this kind of comment isn't helpful, or the code here isn't maintained anymore, please let me know - I might just stumble upon something else.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.