govuk-react / govuk-react/govuk-react

Review clearing by default without any nested floats

Open
#270 1 comment 0 reactions 0 assignees View on GitHub
good first issue triage
Dominant language
TypeScript
Stars
458
Forks
89
PR merge metrics
No merged PRs in 30d

Description

I (think I) understand the reason for adding `clear: left` to containers that could have potential floats that would need clearing but I personally think it would be more elegant to add them on a case-by-case basis. Removing them would also ensure this codebase follows GDS closely.

Hopefully we can move away from using floats where flexbox would be more suitable in the future also.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.