gotify / gotify/server

OIDC: Additional external redirect_url whitelist

Open
#969 0 comments 0 reactions 0 assignees View on GitHub
a:feature
Dominant language
Go
Stars
15.9k
Forks
873
Avg merge
2d 22h
Merged PRs (30d)
6

Description

The POST /auth/oidc/external/authorize and POST /auth/oidc/external/token endpoints currently accept any redirect_uri from the request body and forward it verbatim to the OIDC provider

The OIDC provider is expected to enforce its own redirect_uri allowlist, so this isn't exploitable against a correctly configured IdP. This is an extra change that may reduce the risk of misconfigured IdP servers.

Originally reported privately by @overgrowncarrot1.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.