gotify / gotify/server

OIDC: Disallow changing admin permissions for oidc users when OIDC group mapping is configured

Open
#1,037 0 comments 0 reactions 0 assignees View on GitHub
a:feature
Dominant language
Go
Stars
15.9k
Forks
873
Avg merge
2d 22h
Merged PRs (30d)
6

Description

When a local user is linked with a oidc identity. Or an oidc identity changes the password. They can still use local login. We currently don't really define a account type, so if the password is set, the user can use local auth. If the oidc_id is set, the user can login via oidc.

With the addition of #1033 the admin permissions are synced on oidc login and we maybe want to restrict changing the admin permissions for oidc users.

We also maybe want to disable local login when the user is linked to an oidc identity.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the OIDC login flow and the admin-permission synchronization introduced by #1033. Clarify whether the intended change is to block local permission edits, disable local login for linked users, or both. Done should include an agreed behavior and tests covering linked OIDC identities, password changes, local authentication, and permission updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication, authorization, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.