gotestyourself / gotestyourself/gotest.tools

icmd is not usable when the tested binary expects a console

Open
#287 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
576
Forks
54
Avg merge
6d 3h
Merged PRs (30d)
2

Description

Assume you want to pass along a pty, because the binary you are testing expects a console.

Since icmd does replace stdout with an io.Multiwriter, this won't work.
icmd should not do that, or at least expose a way for the user to prevent icmd from doing it (eg: `io.Copy` would be a better approach)

I appreciate this *might* be a minority case that icmd does not want to cover, but then, current implementation feels wrong.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.