gotestyourself / gotestyourself/gotest.tools

Allow comparing zero for DurationWithThreshold

Open
#240 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
576
Forks
54
Avg merge
6d 3h
Merged PRs (30d)
2

Description

I found `DurationWithThreshold` returns false if both of the values are zero.

https://github.com/gotestyourself/gotest.tools/pull/62/files#diff-d952cf5be65334da619358823c8ff4669961b0d9a30e85d542caad125beac4c6R20

I guess if both of them are zero, we should return true to compare all test cases in the consistent way.

What do you think?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.