gotestyourself / gotestyourself/gotest.tools

Fix fs.WithSymlink lack of symmetry

Open
#192 0 comments 1 reaction 0 assignees View on GitHub
bug help wanted
Dominant language
Go
Stars
576
Forks
54
Avg merge
6d 3h
Merged PRs (30d)
2

Description

`fs.WithSymlink`, when used with a Dir or File creates a link with an absolute path, when used with a Manifest it expects a relative path.

I think both cases could be useful, but having different behaviour in the same function is a problem. I think this function can be deprecated and replaced with: `fs.WithRelativeSymlink` and `fs.WithAbsoluteSymlink` which have consistent behaviour for all types of `Path`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.