googleworkspace / googleworkspace/apps-script-samples

Incorrect File Name(s) (Trailing '2')

Open
#406 0 comments 0 reactions 1 assignee View on GitHub

@davidharcombe is already working on this.

Since Jun 9, 2023.

Dominant language
JavaScript
Stars
5.2k
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

Summary

TimeZone settings (& other attributes/dependencies) for some of the sub-packages or sub-modules for the apps-script-samples does not load properly due to improperly named manifest files.

operating-system@build-machine:~/Documents$ find . -type f -name 'appsscript2.json' 2>/dev/null

./apps-script-samples-main/data-studio/appsscript2.json

TODO
Fix the file name(s) for these two Apps Script initialization JSON files (i.e. appsscript.json not appsscript2.json)!:

  • data-studio/appsscript2.json

CAVEAT:
It is realized that these files might be intentionally misspelled as a means to ignore the sub-project or sub-module while keeping version control on the files, but perhaps there is a better way to accomplish such exclusions while maintaining referential integrity.

Expected Behavior

Import of the sub-packages should reflect the proper time zones and/or other dependencies when loaded into Google Workspace's Apps Script editor.

Sample URL: https://developers.google.com/drive/v2/reference/files/insert
Description: Instructions for importing modules and/or projects into Apps Script for use with Google Workspace.

Actual Behavior

Import of the sub-packages does not reflect the proper time zones and/or other dependencies (e.g. included libraries) when loaded into Google Workspace's Apps Script editor.

Steps to Reproduce the Problem

  1. Traverse the source tree with your preferred tool(s).
  2. Determine the location of all files named appsscript2.json
  3. Rename the file(s) appsscript.json in the respective directories
  4. Import the files into the Apps Script environment within Google Workspaces
  5. Ensure that the Apps Script editor recognizes the file name(s) appropriately and applies the appropriate configuration to the subprojects.

NOTE: File name(s) should not have numbered suffixes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.