googlesamples / googlesamples/unity-jar-resolver

[FR] Force LF line ending for AndroidResolverDependencies.xml in all OS

Open
#755 0 comments 0 reactions 0 assignees View on GitHub
type: feature request
Dominant language
C#
Stars
1.5k
Forks
371
Avg merge
14h 21m
Merged PRs (30d)
3

Description

### Feature proposal

* EDM4U Component: Android Resolver
* EDM4U version: 1.2.183

When I clean build my project on my Windows machine, the only text file that has CRLF line endings after the build is `AndroidResolverDependencies.xml`. This creates git diff noise.

As workaround, I added the following line to my .gitattributes, which would enable CRLF on git checkout on Windows:

```
ProjectSettings/AndroidResolverDependencies.xml text -eol
```

It would be nice if the XmlTextWriter could be configured to always use LF instead.

I think this is the relevant line:

https://github.com/googlesamples/unity-jar-resolver/blob/6eee66190fb6d7182518cc3b41e3919e054699b6/source/AndroidResolver/src/PlayServicesResolver.cs#L108

The same change was done before for `GvhProjectSettings.xml`: https://github.com/googlesamples/unity-jar-resolver/issues/386.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.