googlesamples / googlesamples/unity-jar-resolver

[FR] Abort build if pod install failed

Open
#433 3 comments 0 reactions 0 assignees View on GitHub
type: feature request
Dominant language
C#
Stars
1.5k
Forks
371
Avg merge
14h 21m
Merged PRs (30d)
3

Description

### Feature proposal

* EDM4U Component: iOS Resolver

When `pod install` fails, the iOS Resolver only shows a log message but the build continues: https://github.com/googlesamples/unity-jar-resolver/blob/822d341110f9ecf770f872fdad5f98cbb0531d8b/source/IOSResolver/src/IOSResolver.cs#L2567
Ideally I would like the build to abort because, as the log message says, _This will will likely result in an non-functional Xcode project_ (double "will" BTW), and continuing the process is most likely just a waste of time.

Would it be possible to convert the log into an exception ([BuildFailedException](https://docs.unity3d.com/ScriptReference/Build.BuildFailedException.html)?) that aborts the build?

In case you think there's some use case where people may want to continue the build, could we have it as an option? Alternatively, adding a way to query the result of this step would allow us to abort in a later custom step.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.