googlesamples / googlesamples/unity-jar-resolver

Issues when saving analytics settings to GvhProjectSettings.xml

Open
#387 5 comments 2 reactions 0 assignees View on GitHub
type: feature request
Dominant language
C#
Stars
1.5k
Forks
371
Avg merge
14h 21m
Merged PRs (30d)
3

Description

### Please fill in the following fields:
Unity editor version: 2018.4.23f1
External Dependency Manager version: 1.2.156
Source you installed EDM (from .unitypackage or Unity Package Manager): .unitypackage
Features in External Dependency Manager in use (Android Resolver, iOS Resolver, VersionHandler, etc.): Android Resolver, iOS Resolver, VersionHandler
Plugins SDK in use (Firebase, Admob, Facebook, etc.): Firebase, Facebook
Platform you are using the Unity editor on (Mac, Windows, or Linux): Mac
Platform you are targeting (iOS, Android, and/or desktop): Android
Scripting Runtime (Mono, and/or IL2CPP): IL2CPP

### Please describe the issue here:
Analytics settings are not being properly saved. After the popup shows up, if you select "No" it will add a line like this:
``
The same thing happens if you change the settings for "Yes" then change it back to "No".

Even if values are committed to the repository, other users will still see both popups (For the dependency manager analytics and for firebase analytics).

![image](https://user-images.githubusercontent.com/62283059/86613184-82a21b80-bfb1-11ea-937c-73dd969063ed.png)

![image](https://user-images.githubusercontent.com/62283059/86613226-9057a100-bfb1-11ea-8f2c-b14355949713.png)

![image](https://user-images.githubusercontent.com/62283059/86613252-9a799f80-bfb1-11ea-8ff1-59c3544c6234.png)

### Please answer the following, if applicable:
What's the issue repro rate? (eg 100%, 1/5 etc) 100%

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.