googlesamples / googlesamples/android-media-controller

Bug: Can not give a query to "Play From Search Test"

Open
#41 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
482
Forks
138
PR merge metrics
No merged PRs in 30d

Description

# Description
In the class `TestDescriptor` the `playFromSearch` in line 39 sets `queryRequired` to `false`.
Therefore, the query is never shown in the configuration dialog, the dialog only adds EditText fields for tests with this field set to `true`

# How to reproduce
- Install current version of the Media Controller Tester app
- Test any app that declares "PLAY_FROM_SEARCH" support
- Go to test suites, run either basic tests or auto tests -> "Play from Search Test" fails (if the app doesn't play anything from an empty search query

# Expected behaviour
The test result card says
> Enter the search query in the query field

So that's what I would expect, to be able to enter that. Furthermore, one might argue that an app should get a passing grade when the search query is empty and the player ends up in either the starting state or any other state than "error"

# Devices, OS
All

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.