The comment incorrectly describes the direction of anonymous shared memory() usage

Open
#495 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
c
Domain
documentation

Research direction

Open Sources/libreprl/libreprl-posix.c and compare the data_out declaration comment with the memcpy call that copies the script into its mapping. Correct the comment to reflect the REPRL → Child direction, then review nearby shared-memory comments for consistency.

Written by the indexing model from the issue text.

Description

In the file Sources/libreprl/libreprl-posix.c, data_out is defined as:

// Data channel Child -> REPRL
struct data_channel* data_out;

However, in the reprl process, it is actually used as follows (also in Sources/libreprl/libreprl-posix.c):

// Copy the script to the data channel.
memcpy(ctx->data_out->mapping, script, script_size);

Thus, the actual usage direction of data_out should be REPRL → Child instead."

Dominant language
Swift
Stars
2.3k
Forks
367
Avg merge
23h 53m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleprojectzero/fuzzilli

All issues in googleprojectzero/fuzzilli

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.