googlemaps / googlemaps/js-route-optimization-app

Style theater

Open
#179 1 comment 0 reactions 0 assignees View on GitHub
triage me type: bug
Dominant language
TypeScript
Stars
139
Forks
53
Avg merge
3d 23h
Merged PRs (30d)
10

Description

This repository is set up to "Squash Merge" _and_ has a "Conventional Commit" presubmit check to enforce a style of commit message.

But "Squash Merge" obliterates the commit messages that "Conventional Commit" tries to enforce. Instead the Pull Request content is used - so people submitting pull requests are forced to do throw-away work.

https://lore.kernel.org/lkml/CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com/

This repository needs to be on a "Rebase" workflow for the "Conventional Commit" presubmit check to provide any added value. **Or** we should disable the conventional commits presubmit because it's not actually enforcing anything.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.