googlemaps / googlemaps/js-markerclusterer

[FR] Compile this library in strict mode

Open
#642 1 comment 0 reactions 1 assignee Claimed by @wangela View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
293
Forks
104
Avg merge
3m
Merged PRs (30d)
18

Description

There are a few typing issues in the code

i.e.

https://github.com/googlemaps/js-markerclusterer/blob/e8eecf49b1d1f59579f3316c705f2c131b796560/src/algorithms/grid.ts#LL49C1-L61C4

`this.state = { zoom: null };` is not compatible with `protected state: { zoom: number };`

This lib should be compiled with `{ strict: true}` in the `tsconfig.json`.

WDYT @amuramoto ?

(I could volunteer to help)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.