googlemaps / googlemaps/android-maps-compose

RFC: Remove experimental MapEffect composable

Open
#267 4 comments 4 reactions 0 assignees View on GitHub
needs more info priority: p3 type: feature request
Dominant language
Kotlin
Stars
1.3k
Forks
181
Avg merge
2d 23h
Merged PRs (30d)
18

Description

If you would like to recommend against this proposal, please comment below or react with 👎 .
-------------

MapEffect was added in #140 to expose the underlying GoogleMap Maps SDK object to enable extension and usages such as clustering with the utility library.

With Compose-native clustering being added by #258, we're hoping that MapEffect is no longer needed. Providing direct access to the map is potentially buggy as noted in [this comment](https://github.com/googlemaps/android-maps-compose/pull/140#pullrequestreview-1003063252).

It seems like MapEffect would still be necessary for other Android Maps Utils such as GeoJSON layer (#29) and KML layer (#129).

**Please comment below if you have other use cases that would require exposing the map object.**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.