googlemaps-samples / googlemaps-samples/android-samples
Move maps-rx snippets to app-rx snippets app
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 2.5k
- Forks
- 3.1k
- Avg merge
- 3d 54m
- Merged PRs (30d)
- 4
Description
Currently the snippets for Maps RX are in the snippets/app (introduced in #902).
Now that we have separate snippet apps for the various libraries, we should move those files to https://github.com/googlemaps-samples/android-samples/tree/main/snippets/app-rx.
I suspect that the Rx snippets might have minSDK 24 so once these move out of snippets/app (meant for the Maps SDK for Android alone), we can revert minSDK for snippets/app to 21.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the Maps RX snippets currently under snippets/app with the target snippets/app-rx directory. Move the relevant files and inspect the app configuration to determine whether snippets/app can return to minSDK 21 while the RX app keeps its required minSDK. Done means the snippets are isolated in app-rx and both configurations remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- build-system, mobile
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100