googleforgames / googleforgames/open-match

Helm chart `query.replicas` values are ignored if less than 3

Open Beginner friendly
#1,637 0 comments 0 reactions 0 assignees View on GitHub
kind/bug
Dominant language
Go
Stars
3.4k
Forks
359
PR merge metrics
No merged PRs in 30d

Description

**What happened**:

When I install open-match with the value `query.replicas=1`, 3 replicase are still instantiated.

**What you expected to happen**:

I expected for there to only be 1 replica.

**How to reproduce it (as minimally and precisely as possible)**:

`helm install open-match --create-namespace --namespace open-match open-match/open-match --set query.replicas=1`

**Anything else we need to know?**:

This is caused because the value `global.kubernetes.horizontalPodAutoScaler.query.minReplicas` defaults to `3` (https://github.com/googleforgames/open-match/blob/main/install/helm/open-match/values.yaml#L254C1-L254C23), when all other services default to `1`. If there is a strong reason why the `query` service shouldn't be able to go less than 3 replicas in extremely light loads, then there should be some additional documentation on `query.replicas` to state that this setting must also be reduced if desired.

**Output of `kubectl version`**:

```
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.0", GitCommit:"b46a3f887ca979b1a5d14fd39cb1af43e7e5d12d", GitTreeState:"clean", BuildDate:"2022-12-08T19:58:30Z", GoVersion:"go1.19.4", Compiler:"gc", Platform:"windows/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3+k3s1", GitCommit:"fe9604cac119216e67f8bd5f14eb5608e3bcd3cf", GitTreeState:"clean", BuildDate:"2023-06-26T16:49:54Z", GoVersion:"go1.20.5", Compiler:"gc", Platform:"linux/amd64"}
```

**Cloud Provider/Platform (AKS, GKE, Minikube etc.)**:

Rancher Desktop (local)

**Open Match Release Version**:

`1.8.0`

**Install Method(yaml/helm)**:

`helm`

Contributor guide

Open the contributing guide

Research direction

Start with install/helm/open-match/values.yaml, especially global.kubernetes.horizontalPodAutoScaler.query.minReplicas and the query.replicas setting. Reproduce the issue with the provided helm install command, then inspect the chart's query deployment and autoscaler configuration. Done means setting query.replicas=1 results in one query replica, or the values are documented if the minimum is intentional.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.