googlefonts / googlefonts/ufo2ft
Auto-generated kern feature could have wrong languagesystems
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 176
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Description
Does anyone understand why the current ufo2ft code runs a regexp over features.fea to find the language systems for the auto-generated features? The current logic seems a little surprising, and it might not work reliably.
-
The current logic assumes that there’s a manually entered feature file. That’s not guaranteed — a valid UFO may just
kerning.plistbut nofeatures.fea. -
Why should the languagesystems of some random GSUB or
aaltfeature determine the languagesystems for thekernfeature? -
The current regexp doesn’t actually retrieve the feature content in a reliable way. A feature file can include other feature files. Also, it doesn’t catch
scriptstatements.
Instead of the current logic, why doesn’t the code consider the Unicode codepoints being kerned? It would be tempting to just re-write this code, but I’d like to understand the rationale behind the current logic. Maybe there’s a reason for it?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ufo2ft code that runs a regexp over features.fea to derive language systems for auto-generated features. Read the surrounding feature-generation logic and inspect how missing feature files, included files, and script statements are handled. Done means the rationale is documented and a reliable replacement behavior is agreed for kern language systems.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100