googlefonts / googlefonts/picosvg

decide whether to support `<style>` element; or explicitly error out

Open
#296 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
220
Forks
17
PR merge metrics
No merged PRs in 30d

Description

currently we only support style _attributes_ but not a `` element. When the latter is present, picosvg ignores it silently but then produces incorrect results (e.g. if the `fill` attributes are defined within the embedded stylesheet, then the paths will appear black).

I propose for now we raise an error and request the user to fix the input.

Contributor guide

Open the contributing guide

Research direction

The issue names no source file or test. Start by locating the SVG handling for elements and existing error tests; done means embedded styles no longer produce silently incorrect output, with the chosen behavior covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.