googlefonts / googlefonts/picosvg

Reuse of arcs is poor

Open
#271 3 comments 0 reactions 1 assignee Claimed by @rsheeter View on GitHub
Dominant language
Python
Stars
220
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Shapes like this fail to find reuse:

![0](https://user-images.githubusercontent.com/6466432/168452632-cf816801-9cb0-4594-9dcb-c797d82eb178.svg)

Appears to relate to arcs, specifically arcs whose start/end is almost the same for at least one dimension. For example,

```
M104.64,10.08 A40.64 6.08 0 1 1 23.36,10.08 A40.64 6.08 0 1 1 104.64,10.08 Z
M99.63,23.34 A36.19 4.81 0 1 1 27.25,23.34 A36.19 4.81 0 1 1 99.63,23.34 Z
```

Because the arcs start/end has identical y we fail to compute a y-scale adjustment.

Observed in sanity checking nanoemoji part files for ones that failed (donor is null).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.