googlefonts / googlefonts/glyphsLib

Names shouldn’t be required for intermediate/brace layers either

Open
#996 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

I programmatically created some intermediate/brace layers (without GSLayer.name) in Glyphs, and they worked fine, but glyphsLib isn’t able to export them to UFO layers because of this validation:

https://github.com/googlefonts/glyphsLib/blob/e2ebf5b517d59bec0c9437da3a748c58f2999911/Lib/glyphsLib/builder/builders.py#L297-L304

The condition `not layer._is_bracket_layer()` should be extended to cover any types of layer that have a synthesized name in the built UFO, in particular intermediate/brace layers.

Contributor guide

Open the contributing guide

Research direction

Start in Lib/glyphsLib/builder/builders.py at the validation around lines 297–304. Trace how intermediate and brace layers receive synthesized names in the built UFO, then adjust the validation so unnamed layers that are handled that way can be exported. Done means programmatically created unnamed intermediate and brace layers export successfully to UFO layers.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.