googlefonts / googlefonts/glyphsLib

there's currently no way to disable adding the EraseOpenCornersFilter

Open
#788 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

Currently, it's always added unconditionally when exporting .glyphs to UFOs

https://github.com/googlefonts/glyphsLib/blob/ee5e1fbbde0e40a0352c5c4444e4131020662f6a/Lib/glyphsLib/builder/font.py#L86-L88

Sometime a user may convert their UFOs to .glyphs to do things in it, and then they want to convert them back to UFOs without that filter messing with their outlines. We need to provide a way to disable it.

see https://github.com/googlefonts/fontmake/issues/897 for related discussion

Contributor guide

Open the contributing guide

Research direction

Start in Lib/glyphsLib/builder/font.py at lines 86-88, where EraseOpenCornersFilter is added during .glyphs-to-UFO export. Read the export options and the related fontmake issue to determine how disabling should be exposed. Done means users can convert UFOs without the filter while existing exports retain current behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.