googlefonts / googlefonts/glyphsLib

GSFontMaster.name is not the same as in Glyphsapp

Open
#688 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

Some fonts will have different GSFontMaster.name with glyphsLib than with Glyphsapp.

This is because GSFontMaster._joinName() uses the width, weight, customName order but Glyphsapp apparently uses the weight, width, customName order instead.
https://github.com/googlefonts/glyphsLib/blob/86cbeb56e4c3b26a8c1d5a6fe8de40b3c936b54c/Lib/glyphsLib/classes.py#L1594-L1606

Contributor guide

Open the contributing guide

Research direction

Start in Lib/glyphsLib/classes.py at GSFontMaster._joinName(), linked in the issue. Compare its width, weight, customName ordering with Glyphsapp’s weight, width, customName ordering, then verify that affected GSFontMaster.name values match Glyphsapp.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.