googlefonts / googlefonts/glyphsLib
Height of the rotated mark glyphs
- Dominant language
- Python
- Stars
- 201
- Forks
- 56
- Avg merge
- 17m
- Merged PRs (30d)
- 1
Description
from [#115](https://github.com/googlefonts/glyphsLib/issues/115), [#557](https://github.com/googlefonts/glyphsLib/issues/557)
I think the rotated mark glyphs should be set to 'hmtx.AdvancedWidth=1,000, vmtx.AdvancedHeight=0'. But, the glyph with category 'Mark' and subCategory 'Nonspacing' is forced to be set to 'hmtx.AdvancedWidth=0'.
I wish glyphs named '*.rotat' or '*.vert' or '*.vrt2' were set to 'vmtx.AdvancedHeight=0' instead of 'hmtx.AdvancedWidth=0'.
Contributor guide
Research direction
Start by reading the linked issues #115 and #557, then locate the glyph conversion entry point that assigns metrics for rotated mark glyphs. Verify how names ending in .rotat, .vert, or .vrt2 are handled and compare that behavior with the requested hmtx.AdvancedWidth=1,000 and vmtx.AdvancedHeight=0 values; done means the relevant glyphs receive those metrics without the Nonspacing override.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100