googlefonts / googlefonts/glyphsLib

Maybe filter out duplicate custom parameters and ensure master names are unique

Open
#500 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

Stumbled over a .glyphs file that had two custom parameters for "Master Name" that were the same. Some masters had the same name even, which lead to TTFs overwriting each other or something when doing `fontmake -m something.designspace -i -o variable`.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how glyphsLib reads custom parameters and master names from a .glyphs file, then reproduce the problem with the fontmake command described in the issue. Done means duplicate "Master Name" parameters are filtered and master names remain unique so generated TTFs do not overwrite one another.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.