googlefonts / googlefonts/glyphsLib

Master names: if parts of name not in predefined MASTER_NAME_*, mishandling might occur

Open
#481 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

In the test font `BraceTestFont.glyphs` included in https://github.com/googlei18n/glyphsLib/pull/478, I noticed that when I named the "Light Condensed" master "Thin Condensed", the final style name was "Thin Condensed" whereas "Bold Condensed" was "Condensed Bold" (the test font intentionally places the width axis before the weight axis). The "Light Condensed" master's `_name` attribute was set to the name, but it wasn't set in the "Bold Condensed" master. I suppose this is because "Thin" does not appear in the list at https://github.com/googlei18n/glyphsLib/blob/23f6290755adef5107f85921462718de82f2578f/Lib/glyphsLib/classes.py#L1326.

Explicit master naming was introduced in 2.5 if I remember correctly... Maybe the code needs to be changed to assume the new naming way and prefer the master name for the style name?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.