googlefonts / googlefonts/glyphsLib

parse_hint_target arguments

Open
#446 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

https://github.com/googlei18n/glyphsLib/blob/cfef8fb7d189c3e52ba89b6c6ddaa99a1e85ff8d/Lib/glyphsLib/classes.py#L243

`parse_hint_target()` should accept indexes with 2, 3 and 4 values. {1, 2}, {1, 2, 3}, {1, 2, 3, 4}. That happens with TrueType hints that are attached to interesting segments.

Contributor guide

Open the contributing guide

Research direction

Open Lib/glyphsLib/classes.py at the parse_hint_target() definition referenced in the issue and trace how hint target indexes are parsed. Verify the behavior for two-, three-, and four-value inputs, and consider the existing parsing tests if present. Done means all three input lengths are accepted for TrueType hint targets without regressing existing cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.