googlefonts / googlefonts/glyphsLib

Fix Filter parsing

Open
#366 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

As mentioned in https://github.com/googlei18n/ufo2ft/pull/238:
We need to change the way filter strings are parsed in glyphLib. `Width:+30`, which should add 30 to the width, doesn’t mean the same as`Width:30` or `Width:=30` or `Width:=+30`, which should set the width to 30.

`Width:-30` should substract 30 from the width, while `Width:=-30` should set to the width to 0 since width cannot be negative (`RSB:=-30` and `LSB:=-30` do set RSB and LSB to -30).

Contributor guide

Open the contributing guide

Research direction

The issue identifies filter-string parsing in glyphLib and references pull request #238; start by reading that discussion and locating the parser it identifies. Check the Width, RSB, and LSB examples, and consider the work done when additive and assignment forms produce the specified values, including the non-negative Width behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.