googlefonts / googlefonts/glyphsLib

Converting features from .ufo to .glyphs should allow invalid code

Open
#1,005 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
201
Forks
56
Avg merge
17m
Merged PRs (30d)
1

Description

I’m trying to roundtrip a .glyphs file that happens to have outdated classes with some glyphs that are not in the font.

in `def _to_glyphs_features()` (in features.py), > `FeaDocument()` > `self._doc = parser_.parse()` > `featureLib.parser.Parser.parse()` it checks for missing glyphs. But all we want is to segment the .fea file into individual feature blocks. The code should not required to be valid.

Contributor guide

Open the contributing guide

Research direction

Start in features.py at _to_glyphs_features(), then follow FeaDocument() through self._doc = parser_.parse() and featureLib.parser.Parser.parse(). Reproduce the .glyphs roundtrip with outdated classes and missing glyphs; done means the .fea content is segmented into individual feature blocks without requiring valid glyph references.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.