googlefonts / googlefonts/gftools

[fix-nonhinting] Changing `maxp` `maxSizeOfInstructions` when adding `prep` table

Open
#912 14 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

Hello!

I'd like to preface this by saying that i'm unsure whether or not this needs to be implemented/fixed, but since the `maxp` table handles memory requirements I was thinking that it might be important to get right.

#### Issue description

When I run `gftools fix-unhinted` a `prep` table is added to the font but the `maxSizeOfInstructions` remains unchanged. The `prep` table generated for me has 7 lines(bytes) of instructions and thus this should reflect in the `maxp` table

Interested to know your thoughts and thanks in advance for your help!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.