googlefonts / googlefonts/gftools

Wrong instances in FVAR table

Open
#762 1 comment 0 reactions 0 assignees View on GitHub
bug builder
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

If an defined instance doesn't have the same family name as the one set up in in `config.yaml`, it shouldn't end up in the FVAR table of the variable fonts.

found in https://github.com/RosaWagner/HedvigLetters/commit/2cd282da2077b297b69cf16758144342ed11e32c

- instances defined in Glyphs, only one instance should be included in the FVAR table
Screenshot 2023-10-19 at 12 18 05

- in the config.yaml file:
Screenshot 2023-10-19 at 12 18 26

- FVAR table containing all the defined instances:
Screenshot 2023-10-19 at 12 19 08

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.