googlefonts / googlefonts/gftools
primary script tool: add "Hira" for kana only fonts
- Dominant language
- Python
- Stars
- 283
- Forks
- 73
- Avg merge
- 21h 25m
- Merged PRs (30d)
- 8
Description
In https://github.com/google/fonts/pull/6826, the primary script module in Fontbakery advises for primary script "Hani". Although "Hani" doesn't work, japanese fonts should have the "Jpan" tag. And the one that doesn't support kanji characters should have the tag "Hira".
⚠ WARN: METADATA.pb: Check for primary_script ([com.google.fonts/check/metadata/primary_script](https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/primary_script))
⚠ WARN METADATA.pb: primary_script is 'Hira'
It should instead be 'Hani'. [code: wrong-primary-script]
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.